Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove old ci directory #3198

Merged
merged 3 commits into from
Aug 19, 2022
Merged

Remove old ci directory #3198

merged 3 commits into from
Aug 19, 2022

Conversation

alamb
Copy link
Contributor

@alamb alamb commented Aug 18, 2022

Which issue does this PR close?

re #3045

Rationale for this change

These scripts are for the arrow repo and got copied to datafusion when we split it out of the main repo. They are vestigal and unused

https://github.com/apache/arrow/tree/master/ci

What changes are included in this PR?

  1. remove ci scripts that are not invoked by datafusion CI
  2. Add comments to dev/rust_lint.sh to explain what it is

Are there any user-facing changes?

No

@github-actions github-actions bot added the development-process Related to development process of DataFusion label Aug 18, 2022
@alamb alamb marked this pull request as ready for review August 19, 2022 10:19
Copy link
Member

@andygrove andygrove left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice cleanup!

@alamb alamb merged commit 3df9f80 into apache:master Aug 19, 2022
@alamb alamb deleted the alamb/remove_old_ci branch August 19, 2022 13:44
@ursabot
Copy link

ursabot commented Aug 19, 2022

Benchmark runs are scheduled for baseline = a52dbb0 and contender = 3df9f80. 3df9f80 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ec2-t3-xlarge-us-east-2] ec2-t3-xlarge-us-east-2
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on test-mac-arm] test-mac-arm
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ursa-i9-9960x] ursa-i9-9960x
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ursa-thinkcentre-m75q] ursa-thinkcentre-m75q
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
development-process Related to development process of DataFusion
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants