Clean up CI workflows by removing "matrix" strategy, simplifying names #3196
Conversation
github-actions
bot
removed
the
development-process
Codecov Report
@@ Coverage Diff @@
## master #3196 +/- ##
==========================================
- Coverage 85.87% 85.87% -0.01%
==========================================
Files 291 291
Lines 52885 52885
==========================================
- Hits 45415 45414 -1
- Misses 7470 7471 +1
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
| @@ -395,8 +364,8 @@ jobs: | |||
| key: ${{ runner.os }}-cargo-miri-${{ hashFiles('**/Cargo.lock') }} | |||
| - name: Setup Rust toolchain | |||
| run: | | |||
| rustup toolchain install ${{ matrix.rust }} | |||
| rustup default ${{ matrix.rust }} | |||
| rustup toolchain install nightly-2022-01-17 | |||
There was a problem hiding this comment.
why use this version？
Is there a possibility that this version needs to be updated later?
There was a problem hiding this comment.
I think we probably pinned the version a while ago when some nightly had issues. I think updating it would be a great idea (and as you say a good follow on PR)
There was a problem hiding this comment.
Follow on PR: #3215 (will need some work)
|
Benchmark runs are scheduled for baseline = 72487cf and contender = 4838564. 4838564 is a master commit associated with this PR. Results will be available as each benchmark for each run completes. |
Which issue does this PR close?
Next installment of #3045
Rationale for this change
The CI checks make use of the 'matrix' strategy (see docs) but have only one matrix combination. This makes them overly confusing.
As part of cleaning up the DataFusion CI I am first pruning out unnecessary complexity first
What changes are included in this PR?
Are there any user-facing changes?
No