-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Minor] Remove some redundant code #3169
Conversation
@@ -286,19 +286,13 @@ pub fn create_physical_expr( | |||
|
|||
let list_exprs = list | |||
.iter() | |||
.map(|expr| match expr { | |||
Expr::Literal(ScalarValue::Utf8(None)) => create_physical_expr( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
both match arms are the same. It is interesting clippy didn't tell us about that
Codecov Report
@@ Coverage Diff @@
## master #3169 +/- ##
=======================================
Coverage 85.88% 85.89%
=======================================
Files 291 291
Lines 52770 52766 -4
=======================================
Hits 45321 45321
+ Misses 7449 7445 -4
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
cc @Ted-Jiang |
Benchmark runs are scheduled for baseline = ccd9406 and contender = 8e9a8d5. 8e9a8d5 is a master commit associated with this PR. Results will be available as each benchmark for each run completes. |
Which issue does this PR close?
N/A
Rationale for this change
This is a random cleanup I noticed while working on #3122
What changes are included in this PR?
Simplify code
Are there any user-facing changes?
No