Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add DataFrame::with_column_renamed #2920

Merged
merged 4 commits into from
Jul 16, 2022

Conversation

andygrove
Copy link
Member

Which issue does this PR close?

Closes #2919

Rationale for this change

Convenient to be able to rename columns without applying a full projection manually

What changes are included in this PR?

Add with_column_renamed with tests

Are there any user-facing changes?

No

@github-actions github-actions bot added the core Core DataFusion crate label Jul 15, 2022
@andygrove andygrove mentioned this pull request Jul 15, 2022
@codecov-commenter
Copy link

codecov-commenter commented Jul 15, 2022

Codecov Report

Merging #2920 (319a81e) into master (b5537e7) will increase coverage by 0.01%.
The diff coverage is 91.66%.

❗ Current head 319a81e differs from pull request most recent head 5577ab8. Consider uploading reports for the commit 5577ab8 to get more accurate results

@@            Coverage Diff             @@
##           master    #2920      +/-   ##
==========================================
+ Coverage   85.30%   85.31%   +0.01%     
==========================================
  Files         273      273              
  Lines       49269    49329      +60     
==========================================
+ Hits        42029    42086      +57     
- Misses       7240     7243       +3     
Impacted Files Coverage Δ
datafusion/core/src/dataframe.rs 88.29% <91.66%> (+0.63%) ⬆️
datafusion/expr/src/logical_plan/plan.rs 77.32% <0.00%> (+0.35%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b5537e7...5577ab8. Read the comment docs.

Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

@andygrove andygrove merged commit c528986 into apache:master Jul 16, 2022
@andygrove andygrove deleted the with-column-renamed branch July 16, 2022 14:52
@ursabot
Copy link

ursabot commented Jul 16, 2022

Benchmark runs are scheduled for baseline = 13f026c and contender = c528986. c528986 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ec2-t3-xlarge-us-east-2] ec2-t3-xlarge-us-east-2
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on test-mac-arm] test-mac-arm
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ursa-i9-9960x] ursa-i9-9960x
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ursa-thinkcentre-m75q] ursa-thinkcentre-m75q
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Core DataFusion crate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rename a column name
4 participants