Run clippy with optional features #2918
Conversation
| Err(err).expect( | ||
| format!( | ||
| "pyarrow not found\nExecutable: {}\nPython path: {:?}\n\ | ||
| panic!("pyarrow not found\nExecutable: {}\nPython path: {:?}\n\ |
There was a problem hiding this comment.
This error appears to have just been being lost previously, which is probably not what was intended
| @@ -221,12 +221,12 @@ fn spawn_local_fifo(task: Task) { | |||
| } | |||
|
|
|||
| #[derive(Debug, Clone)] | |||
| pub struct Spawner { | |||
| pub(crate) struct Spawner { | |||
There was a problem hiding this comment.
This wasn't ever meant to be public, it was accidentally made public as a result of moving from a crate-private module. There was no way to actually construct it, so this is not an API change
| @@ -35,7 +35,7 @@ use std::sync::{Arc, Weak}; | |||
| use std::task::{Context, Poll}; | |||
|
|
|||
| /// Spawns a [`PipelinePlan`] using the provided [`Spawner`] | |||
| pub fn spawn_plan(plan: PipelinePlan, spawner: Spawner) -> ExecutionResults { | |||
| pub(crate) fn spawn_plan(plan: PipelinePlan, spawner: Spawner) -> ExecutionResults { | |||
There was a problem hiding this comment.
This is a private module and so this change is practically unnecessary, but needed to placate clippy
tustvold
force-pushed
the
enable-clippy-features
branch
from
e3a5e9c to
7b543ca
Compare
| @@ -18,4 +18,4 @@ | |||
| # under the License. | |||
|
|
|||
| set -ex | |||
| cargo clippy --all-targets --workspace -- -D warnings | |||
| cargo clippy --all-targets --workspace --features avro,jit,pyarrow,scheduler -- -D warnings | |||
There was a problem hiding this comment.
I tried running with
| cargo clippy --all-targets --workspace --features avro,jit,pyarrow,scheduler -- -D warnings | |
| cargo clippy --all-targets --workspace --all-features -- -D warnings |
and sadly it failed
error[E0554]: `#![feature]` may not be used on the stable release channel
--> /Users/alamb/.cargo/registry/src/github.aaakk.us.kg-1ecc6299db9ec823/packed_simd_2-0.3.8/src/lib.rs:214:1
|
214 | / #![feature(
215 | | adt_const_params,
216 | | repr_simd,
217 | | rustc_attrs,
... |
224 | | custom_inner_attributes,
225 | | )]
| |__^
There was a problem hiding this comment.
Sadly there doesn't appear to be an except feature flag
|
Thank you @tustvold |
|
Benchmark runs are scheduled for baseline = d0496b0 and contender = 36b82d7. 36b82d7 is a master commit associated with this PR. Results will be available as each benchmark for each run completes. |
Runs clippy in CI with optional features enabled, and fixes the issues this exposed