Show column names instead of indices in query plans #2690
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
core
andygrove
changed the title
Dandandan
reviewed
Jun 4, 2022
| .iter() | ||
| .map(|i| schema.field(*i).name().as_str()) | ||
| .collect(); | ||
| format!("Some([{}])", names.join(", ")) |
There was a problem hiding this comment.
What about only showing the projection when there is one and ommiting it when there are none.
This could remove the None/Some too:
TableScan a projection=[col1,col2]
vs
TableScan a
There was a problem hiding this comment.
I started out doing that and it broke many tests that were expecting None so I decided to reduce the size of the change. I agree that it would be a nice improvement though. I'm happy to work on that as a follow-on PR.
alamb
approved these changes
Jun 4, 2022
There was a problem hiding this comment.
I think it is a nice improvement -- @Dandandan 's suggestion would make it even more so (though I think it can be done as a follow on PR as well). Thanks @andygrove
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #2689
Rationale for this change
I am comparing query plans between Spark and DataFusion
Spark shows:
DataFusion shows:
I think we should show column names rather than numeric indices so that users don't have to memorize the schemas of the tables in order to comprehend the query plan.
What changes are included in this PR?
Show names instead of indices.
Are there any user-facing changes?
Yes, plans are easier to understand.