-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prepare for datafusion 8.0.0 , ballista 0.7.0 release #2490
Conversation
|
||
[Full Changelog](https://github.com/apache/arrow-datafusion/compare/7.1.0-rc1...8.0.0) | ||
|
||
**Breaking changes:** |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
😮 -- lots of stuff has happened
ea1ee45
to
60c2d2f
Compare
Something is wrong with the changelogs. They are way too small now. |
@andygrove did i get the |
Yes, |
great thanks. i wrote that at the same time you were saying something wrong with changelogs lol |
@matthewmturner Change logs look good now. I see |
Sorry about that -- I appear to have missed I step. I created the 7.1.0-rc1 tag, but never made a 7.1.0 tag (should be the same commit as 7.1.0-rc1). I am happy to do so if that would help https://github.com/apache/arrow-datafusion/releases/tag/7.1.0-rc1 |
Yes, I generated the change log from 7.1.0-rc1 this time and that worked fine. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me . Thank you @andygrove
ballista/CHANGELOG.md
Outdated
@@ -19,6 +19,154 @@ | |||
|
|||
# Changelog | |||
|
|||
## [8.0.0](https://github.com/apache/arrow-datafusion/tree/8.0.0) (2022-05-12) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder if it is confusing to have ballista be version 7 but the changelog refer to version 8?
Maybe it makes sense to change the ballista version to 8.0.0 (and skip releasing version 7.0.0) for convenience and then when we split the repo (e.g. #2502 ) we can let the versions diverge
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, it is confusing for sure, and Ballista is actually 0.7.0 not 7.0.0.
My preference would be to move Ballista as soon as possible after this release and keep the version < 1.0.0.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think I should have used different parameters when generating the ballista changelog. Our instructions are not correct here ... I will do this now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I should have run ./dev/release/update_change_log-ballista.sh master ballista-0.7.0 ballista-0.6.0
.
- Support Multiple row layout [\#2188](https://github.com/apache/arrow-datafusion/issues/2188) | ||
- Discussion: Is Ballista a standalone system or framework [\#1916](https://github.com/apache/arrow-datafusion/issues/1916) | ||
|
||
**Merged pull requests:** |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"not bad" -- this is a pretty awesome list of features 👍
Thanks! |
## [ballista-0.7.0](https://github.com/apache/arrow-datafusion/tree/ballista-0.7.0) (2022-05-12) | ||
|
||
[Full Changelog](https://github.com/apache/arrow-datafusion/compare/7.1.0-rc1...ballista-0.7.0) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@alamb This looks better now although still slightly confusing because there is also a reference to 7.1.0-rc1
but I think we can live with that.
Which issue does this PR close?
Closes #2392
Rationale for this change
We want to release a new version
What changes are included in this PR?
Are there any user-facing changes?
No