Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare for datafusion 8.0.0 , ballista 0.7.0 release #2490

Merged
merged 8 commits into from
May 12, 2022

Conversation

andygrove
Copy link
Member

@andygrove andygrove commented May 9, 2022

Which issue does this PR close?

Closes #2392

Rationale for this change

We want to release a new version

What changes are included in this PR?

  • Bump version numbers
  • Generate changelogs
  • Update versions in docs

Are there any user-facing changes?

No

@andygrove andygrove self-assigned this May 9, 2022
@github-actions github-actions bot added ballista datafusion Changes in the datafusion crate development-process Related to development process of DataFusion labels May 9, 2022

[Full Changelog](https://github.com/apache/arrow-datafusion/compare/7.1.0-rc1...8.0.0)

**Breaking changes:**
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😮 -- lots of stuff has happened

@andygrove andygrove force-pushed the prep-for-8.0.0-release branch from ea1ee45 to 60c2d2f Compare May 12, 2022 15:19
@andygrove andygrove changed the title WIP: Prepare for 8.0.0 release Prepare for 8.0.0 release May 12, 2022
@andygrove andygrove marked this pull request as ready for review May 12, 2022 15:22
@andygrove
Copy link
Member Author

@alamb @tustvold @yjshen Here is the 8.0.0 release PR. One issue is that there is no 7.1.0 tag so I generated the changelog from 7.0.0. Maybe we need to create the 7.1.0 tag and then generate the changelog again?

@andygrove
Copy link
Member Author

Something is wrong with the changelogs. They are way too small now.

@matthewmturner
Copy link
Contributor

@andygrove did i get the CREATE VIEW feature added in time for this release? I dont see it in changelog

@andygrove
Copy link
Member Author

@andygrove did i get the CREATE VIEW feature added in time for this release? I dont see it in changelog

Yes, CREATE VIEW is definitely in here. Changelogs are wrong and I am not sure why but am looking into it ...

@matthewmturner
Copy link
Contributor

great thanks. i wrote that at the same time you were saying something wrong with changelogs lol

@andygrove
Copy link
Member Author

@matthewmturner Change logs look good now. I see CREATE VIEW in there.

@alamb
Copy link
Contributor

alamb commented May 12, 2022

One issue is that there is no 7.1.0 tag so I generated the changelog from 7.0.0. Maybe we need to create the 7.1.0 tag and then generate the changelog again?

Sorry about that -- I appear to have missed I step. I created the 7.1.0-rc1 tag, but never made a 7.1.0 tag (should be the same commit as 7.1.0-rc1). I am happy to do so if that would help

https://github.com/apache/arrow-datafusion/releases/tag/7.1.0-rc1

@alamb alamb changed the title Prepare for 8.0.0 release Prepare for datafusion 8.0.0 , ballista 7.0.0 release May 12, 2022
@andygrove andygrove changed the title Prepare for datafusion 8.0.0 , ballista 7.0.0 release Prepare for datafusion 8.0.0 , ballista 0.7.0 release May 12, 2022
@andygrove
Copy link
Member Author

One issue is that there is no 7.1.0 tag so I generated the changelog from 7.0.0. Maybe we need to create the 7.1.0 tag and then generate the changelog again?

Sorry about that -- I appear to have missed I step. I created the 7.1.0-rc1 tag, but never made a 7.1.0 tag (should be the same commit as 7.1.0-rc1). I am happy to do so if that would help

https://github.com/apache/arrow-datafusion/releases/tag/7.1.0-rc1

Yes, I generated the change log from 7.1.0-rc1 this time and that worked fine.

Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me . Thank you @andygrove

@@ -19,6 +19,154 @@

# Changelog

## [8.0.0](https://github.com/apache/arrow-datafusion/tree/8.0.0) (2022-05-12)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if it is confusing to have ballista be version 7 but the changelog refer to version 8?

Maybe it makes sense to change the ballista version to 8.0.0 (and skip releasing version 7.0.0) for convenience and then when we split the repo (e.g. #2502 ) we can let the versions diverge

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it is confusing for sure, and Ballista is actually 0.7.0 not 7.0.0.

My preference would be to move Ballista as soon as possible after this release and keep the version < 1.0.0.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I should have used different parameters when generating the ballista changelog. Our instructions are not correct here ... I will do this now.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I should have run ./dev/release/update_change_log-ballista.sh master ballista-0.7.0 ballista-0.6.0.

- Support Multiple row layout [\#2188](https://github.com/apache/arrow-datafusion/issues/2188)
- Discussion: Is Ballista a standalone system or framework [\#1916](https://github.com/apache/arrow-datafusion/issues/1916)

**Merged pull requests:**
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"not bad" -- this is a pretty awesome list of features 👍

@matthewmturner
Copy link
Contributor

@matthewmturner Change logs look good now. I see CREATE VIEW in there.

Thanks!

Comment on lines +22 to +24
## [ballista-0.7.0](https://github.com/apache/arrow-datafusion/tree/ballista-0.7.0) (2022-05-12)

[Full Changelog](https://github.com/apache/arrow-datafusion/compare/7.1.0-rc1...ballista-0.7.0)
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alamb This looks better now although still slightly confusing because there is also a reference to 7.1.0-rc1 but I think we can live with that.

@andygrove andygrove merged commit 5d52b32 into apache:master May 12, 2022
@andygrove andygrove deleted the prep-for-8.0.0-release branch May 12, 2022 23:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
datafusion Changes in the datafusion crate development-process Related to development process of DataFusion
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DataFusion 8.0.0 Release
3 participants