-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move datafusion-cli to new crate #231
Conversation
Codecov Report
@@ Coverage Diff @@
## master #231 +/- ##
=======================================
Coverage 76.46% 76.46%
=======================================
Files 135 134 -1
Lines 23250 23249 -1
=======================================
Hits 17777 17777
+ Misses 5473 5472 -1
Continue to review full report at Codecov.
|
The Dockerfile will also need to be updated (it looks like it has incorrect paths). The Dockerfile also probably needs moving to the new datafusion-cli folder too. |
Co-authored-by: Andy Grove <[email protected]>
Co-authored-by: Andy Grove <[email protected]>
Thanks, I updated the Dockerfile |
LGTM. I can't approve this PR for some reason. Maybe a GitHub glitch .. I will check again later. |
LGTM too. Thanks @Dandandan |
Which issue does this PR close?
Closes #218
Rationale for this change
clap
rustyline
and transitive dependencies) unneeded for the rest of DataFusion, slowing the development cycle down a bit (mainly for clean builds).cargo install datafusion --bin datafusion-cli --release
What changes are included in this PR?
rustyline
versionAre there any user-facing changes?
Users should be able to use datafusion-cli now instead of using the
bin
option inside of datafusion.