fix issue#2058 file_format/json.rs attempt to subtract with overflow

[silence-coding]

fix #2058

[silence-coding]

@alamb Please check it.

[Ted-Jiang]

LGTM, thanks for your contribution.

[xudong963]

It'll be better to add a test for the fix :)

[alamb]

Thank you for the contribution @silence-coding

It'll be better to add a test for the fix :)

I agree with @xudong963 -- can you please provide a test (both to demonstrate what is wrong and help ensure we don't break it again in the future)?

Perhaps you can adapt the reproducer on #2058

[silence-coding]

@alamb @xudong963 That's my problem. I forgot to write test cases.

[alamb]

Sadly I think #2023 added 3.json already -- can you fix this PR to use the name 4.json?

like:

--- a/datafusion/src/datasource/file_format/json.rs
+++ b/datafusion/src/datasource/file_format/json.rs
@@ -236,7 +236,7 @@ mod tests {
 
     #[tokio::test]
     async fn infer_schema_with_limit()  {
-        let filename = "tests/jsons/3.json";
+        let filename = "tests/jsons/4.json";
         let format = JsonFormat::default()
             .with_schema_infer_max_rec(Some(3));
         let file_schema = format
diff --git a/datafusion/tests/jsons/3.json b/datafusion/tests/jsons/4.json
similarity index 100%
rename from datafusion/tests/jsons/3.json
rename to datafusion/tests/jsons/4.json

to resolve the conflict?

[silence-coding]

@alamb fix with schema_infer_limit.json

[silence-coding]

When will the next version be released?

[xudong963]

When will the next version be released?

I think we can open an issue to discuss the next version release.

[alamb]

I think we can open an issue to discuss the next version release.

I created #2095 to start this conversation -- @silence-coding it would be great to hear your perspective if you are thinking of a release directly from master, or a release that has only bug fixes, or something else

[alamb]

Thanks again @silence-coding