Fix bug while merging RecordBatch, add SortPreservingMerge fuzz tester
#1678
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Marking as a draft as I still plan to add a few more cases to this tester (as I work on #1676 ) |
alamb
force-pushed
the
alamb/merge_fuzz
branch
from
fe36f5d to
fbdf721
Compare
alamb
force-pushed
the
alamb/merge_fuzz
branch
from
645e0c8 to
f4cb449
Compare
alamb
changed the title
SortPreservingMerge fuzz testerRecordBatch, Add SortPreservingMerge fuzz tester
alamb
commented
Jan 26, 2022
| @@ -410,40 +410,53 @@ impl SortPreservingMergeStream { | |||
| // Cursor is not finished - don't need a new RecordBatch yet | |||
| return Poll::Ready(Ok(())); | |||
| } | |||
| let mut streams = self.streams.streams.lock().unwrap(); | |||
| let mut empty_batch = false; | |||
There was a problem hiding this comment.
The changes to this file are easier to see if you use a whitespace blind diff:
https://github.com/apache/arrow-datafusion/pull/1678/files?w=1
alamb
commented
Jan 26, 2022
| } | ||
|
|
||
| #[tokio::test] | ||
| async fn test_merge_2_no_overlap() { |
There was a problem hiding this comment.
this test fails without the changes to datafusion/src/physical_plan/sorts/sort_preserving_merge.rs
alamb
changed the title
RecordBatch, Add SortPreservingMerge fuzz testerRecordBatch, add SortPreservingMerge fuzz tester
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Fixes #1676
Includes the code from @yjshen alamb#4 in a separate commit ❤️
Rationale for this change
Despite pretty good testing in
SortPreservingMergethere was at least one case that is not yet covered. This PR addsWhat changes are included in this PR?
'assertion failed: i < self.len()'in array_primitive.rs while merging non overlapping streams #1676Are there any user-facing changes?
Bug is fixed