fix a cte block with same name for many times #1639
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
datafusion
|
It is a unreasonable behavior that a single cte block with the same name for many times. But currently, datafusion doesn't process it correctly. // datafusion
❯ create table t1 as select '123' as c;
0 rows in set. Query took 0.005 seconds.
❯ create table t3 as select '12' as c;
0 rows in set. Query took 0.005 seconds.
❯ with a as (select * from t1), a as (select * from t3) select * from a;
+----+
| c |
+----+
| 12 |
+----+
1 row in set. Query took 0.007 seconds.
//postgres
postgres=# with a as (select * from t1), a as (select * from t2) select * from a;
ERROR: WITH query name "a" specified more than once
LINE 1: with a as (select * from t1), a as (select * from t2) select... |
alamb
reviewed
Jan 22, 2022
datafusion/src/sql/planner.rs
Outdated
| // Process CTEs from top to bottom | ||
| // do not allow self-references | ||
| for cte in &with.cte_tables { | ||
| let cte_name = cte.alias.name.value.clone(); |
There was a problem hiding this comment.
If you do need a hashtable in this function, I think you can avoid cloning the string here (and just store &str in the set):
Suggested change
| let cte_name = cte.alias.name.value.clone(); | |
| let cte_name = cte.alias.name.value.as_ref(); |
alamb
reviewed
Jan 22, 2022
datafusion/src/sql/planner.rs
Outdated
| @@ -213,9 +213,19 @@ impl<'a, S: ContextProvider> SqlToRel<'a, S> { | |||
| ) -> Result<LogicalPlan> { | |||
| let set_expr = &query.body; | |||
| if let Some(with) = &query.with { | |||
| // a `WITH` block can't use the same name for many times | |||
| let mut cte_names = HashSet::new(); | |||
There was a problem hiding this comment.
Since this function gets a hashtable called ctes as a parameter, I wonder if you could check for the name in that hashtable rather than making a new one?
ctes: &mut HashMap<String, LogicalPlan>,There was a problem hiding this comment.
Oh, good catch, we can reuse ctes!
|
Fixed, plz take another look when you have time @alamb |
Dandandan
approved these changes
Jan 22, 2022
houqp
approved these changes
Jan 22, 2022
|
Thanks @xudong963 , @Dandandan and @houqp ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Fix a cte block with same name for many times
Rationale for this change
What changes are included in this PR?
Are there any user-facing changes?