consolidate binary_expr coercion rule code into binary_rule.rs module
#1607
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @liukun4515 |
alamb
changed the title
alamb
changed the title
|
Thanks @alamb |
|
If #1606 merged, I will review this. |
No worries @liukun4515 -- you said that. I just figured I was already changing the code for #1606 so I would make progress here too Also note there is no actual consolidation of the logic -- I just moved the code to the same module. I envision your cleanup to consolidate the actual logic would be in a follow on PR |
alamb
force-pushed
the
alamb/condolidate_coercion
branch
from
0c3ee94 to
90d9a27
Compare
alamb
changed the title
binary_rule.rs module
alamb
force-pushed
the
alamb/condolidate_coercion
branch
from
90d9a27 to
c065f05
Compare
Co-authored-by: xudong.w <[email protected]>
liukun4515
reviewed
Jan 20, 2022
| @@ -293,14 +289,192 @@ fn coercion_decimal_mathematics_type( | |||
| } | |||
| } | |||
|
|
|||
| /// Determine if a DataType is signed numeric or not | |||
| pub fn is_signed_numeric(dt: &DataType) -> bool { | |||
liukun4515
reviewed
Jan 20, 2022
| } | ||
|
|
||
| /// Determine if a DataType is numeric or not | ||
| pub fn is_numeric(dt: &DataType) -> bool { |
liukun4515
reviewed
Jan 20, 2022
| } | ||
| } | ||
|
|
||
| pub(crate) fn is_dictionary(t: &DataType) -> bool { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Builds on #1606, so draft until that is mergedWhich issue does this PR close?
Re #1605
Rationale for this change
While working on #1606 I found it confusing that some of the logic was in
coercion.rsand some inbinary_rule.rsWhat changes are included in this PR?
Moves all binary operator coercion logic into
binary_rule.rs(just code motion, no changes now). I hope that the logic is consolidated more in a future PRAre there any user-facing changes?
no