Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add example on how to query multiple parquet files #1497

Merged
merged 1 commit into from
Dec 31, 2021

Conversation

nitisht
Copy link
Contributor

@nitisht nitisht commented Dec 28, 2021

Which issue does this PR close?

Closes #1484

Rationale for this change

This is a simple change to add an example on how to query multiple Parquet files using Datafusion

What changes are included in this PR?

Are there any user-facing changes?

@github-actions github-actions bot added the datafusion Changes in the datafusion crate label Dec 28, 2021
Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @nitisht

@alamb
Copy link
Contributor

alamb commented Dec 28, 2021

The build failure looks the same as #1498

@nitisht
Copy link
Contributor Author

nitisht commented Dec 29, 2021

Thanks @alamb . Anything I can do to get this merged ?

@nitisht nitisht force-pushed the multiple-parquet-example branch from 91fb07e to a2ba668 Compare December 29, 2021 04:05
@alamb
Copy link
Contributor

alamb commented Dec 29, 2021

@nitisht I will get this merged -- I'll merge in the workaround for the time being while we sort out the quote / arrow stuff upstream

@alamb
Copy link
Contributor

alamb commented Dec 29, 2021

I merged master to your branch to pick up the changes. Hoping for a clean CI run now

@alamb
Copy link
Contributor

alamb commented Dec 29, 2021

@nitisht it looks like there are some clippy and compilation errors. Can you please fix them?

@nitisht nitisht force-pushed the multiple-parquet-example branch from cd4f049 to b557939 Compare December 29, 2021 13:41
@nitisht
Copy link
Contributor Author

nitisht commented Dec 29, 2021

Just pushed some fixes.

@alamb
Copy link
Contributor

alamb commented Dec 30, 2021

🤔 the tests still seem not to be passing

@nitisht nitisht force-pushed the multiple-parquet-example branch from b557939 to 99edb93 Compare December 31, 2021 03:36
@nitisht
Copy link
Contributor Author

nitisht commented Dec 31, 2021

🤔 the tests still seem not to be passing

My apologies, I had not fixed everything. Just fixed the build/clippy issues. Runs fine locally, hopefully the CI should be happy now.

@alamb alamb merged commit 07f5b3d into apache:master Dec 31, 2021
@alamb
Copy link
Contributor

alamb commented Dec 31, 2021

Thanks again @nitisht ! Great first contribution

@AdheipSingh
Copy link

awesome !!
thanks @nitisht @alamb

@nitisht nitisht deleted the multiple-parquet-example branch December 31, 2021 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
datafusion Changes in the datafusion crate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Is it possible to query multiple parquet files ?
3 participants