Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix calculate in many_to_many_hash_partition test. #1463

Merged
merged 2 commits into from
Dec 18, 2021

Conversation

Ted-Jiang
Copy link
Member

Which issue does this PR close?

#1462

Closes #.

@github-actions github-actions bot added the datafusion Changes in the datafusion crate label Dec 18, 2021
@Dandandan
Copy link
Contributor

@Ted-Jiang great find/fix! there is one clippy error:

   --> datafusion/src/physical_plan/repartition.rs:581:24
    |
581 |             .map(|x| x.into_iter().map(|x| x.num_rows()).sum::<usize>())
    |                        ^^^^^^^^^ help: call directly: `iter`
    |
    = note: `-D clippy::into-iter-on-ref` implied by `-D warnings`

@Ted-Jiang
Copy link
Member Author

@Ted-Jiang great find/fix! there is one clippy error:

   --> datafusion/src/physical_plan/repartition.rs:581:24
    |
581 |             .map(|x| x.into_iter().map(|x| x.num_rows()).sum::<usize>())
    |                        ^^^^^^^^^ help: call directly: `iter`
    |
    = note: `-D clippy::into-iter-on-ref` implied by `-D warnings`

Thanks, how do i check this before commit ? i can not find in Developer's guide 😂

@Dandandan
Copy link
Contributor

@Ted-Jiang great find/fix! there is one clippy error:

   --> datafusion/src/physical_plan/repartition.rs:581:24
    |
581 |             .map(|x| x.into_iter().map(|x| x.num_rows()).sum::<usize>())
    |                        ^^^^^^^^^ help: call directly: `iter`
    |
    = note: `-D clippy::into-iter-on-ref` implied by `-D warnings`

Thanks, how do i check this before commit ? i can not find in Developer's guide 😂

You can run cargo clippy

@Ted-Jiang great find/fix! there is one clippy error:

   --> datafusion/src/physical_plan/repartition.rs:581:24
    |
581 |             .map(|x| x.into_iter().map(|x| x.num_rows()).sum::<usize>())
    |                        ^^^^^^^^^ help: call directly: `iter`
    |
    = note: `-D clippy::into-iter-on-ref` implied by `-D warnings`

Thanks, how do i check this before commit ? i can not find in Developer's guide 😂

You can run cargo clippy and you get the warnings 👍

@Dandandan Dandandan merged commit 35d65fc into apache:master Dec 18, 2021
@Dandandan
Copy link
Contributor

Thank you @Ted-Jiang

@houqp houqp added the bug Something isn't working label Dec 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working datafusion Changes in the datafusion crate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants