Support Utf8View to numeric coercion
#14377
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alamb
changed the title
Utf8View to numeric coercsion
This was referenced Jan 30, 2025
alamb
changed the title
Utf8View to numeric coercsionUtf8View to numeric coercion
alamb
commented
Jan 30, 2025
| @@ -684,8 +684,10 @@ fn string_numeric_coercion(lhs_type: &DataType, rhs_type: &DataType) -> Option<D | |||
| match (lhs_type, rhs_type) { | |||
| (Utf8, _) if rhs_type.is_numeric() => Some(Utf8), | |||
| (LargeUtf8, _) if rhs_type.is_numeric() => Some(LargeUtf8), | |||
| (Utf8View, _) if rhs_type.is_numeric() => Some(Utf8View), | |||
There was a problem hiding this comment.
this is the only code change
|
Looking good, thx for putting this together |
comphead
approved these changes
Feb 3, 2025
alamb
added a commit
to alamb/datafusion
that referenced
this pull request
Feb 3, 2025
* Test for string / numeric coercion * fix tests * Update tests * Add tests to stringview * add numeric coercion
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
45.0.0#14008Utf8Viewinnumeric_string_coercion#13366Rationale for this change
This allows Stringview to be compared to numeric values, consistently with normal stirngs
What changes are included in this PR?
Utf8Viewinnumeric_string_coercion#13366Are these changes tested?
Yes unit tests are
Are there any user-facing changes?
Yes, queries that work with Utf8 will now also work with Utf8View