Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

consolidation of examples: date_time_functions #14240

Merged
merged 2 commits into from
Jan 23, 2025

Conversation

logan-keede
Copy link
Contributor

@logan-keede logan-keede commented Jan 22, 2025

Which issue does this PR close?

Rationale for this change

All functions are related to date_time functionality, it is easier to navigate if they are together.
assertions allow us to view expected output without running, can also serve as partial tests.
as mentioned in #13939 by @comphead

What changes are included in this PR?

Are these changes tested?

No. just examples.

Are there any user-facing changes?

No.

@logan-keede
Copy link
Contributor Author

cc @alamb @comphead

@comphead
Copy link
Contributor

Thanks @logan-keede triggering the run

Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @logan-keede -- this looks like a great improvement to me ❤️

FYI @Omega359 as I think you contributed many of these examples originally

@alamb alamb changed the title consolidation: date_time_functions consolidation of examples: date_time_functions Jan 22, 2025
Copy link
Contributor

@comphead comphead left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @logan-keede for removing also to_char.rs I doubled checked it and it refers to conversion from dates so it perfectly fits to date and time examples

@comphead comphead merged commit 44cf77f into apache:main Jan 23, 2025
28 checks passed
@logan-keede
Copy link
Contributor Author

thanks @logan-keede for removing also to_char.rs I doubled checked it and it refers to conversion from dates so it perfectly fits to date and time examples

thanks, but credit for noticing that that goes to @alamb for mentioning it in #7013 (comments)

@alamb
Copy link
Contributor

alamb commented Jan 24, 2025

thanks @logan-keede for removing also to_char.rs I doubled checked it and it refers to conversion from dates so it perfectly fits to date and time examples

thanks, but credit for noticing that that goes to @alamb for mentioning it in #7013 (comments)

lol all I do now it seems is to write tickets

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[EPIC] Improve examples to make them easier to navigate
3 participants