feat: add alias() method for DataFrame
#14127
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
comphead
reviewed
Jan 14, 2025
| @@ -2646,3 +2646,58 @@ async fn boolean_dictionary_as_filter() { | |||
|
|
|||
| assert_batches_eq!(expected, &result_df.collect().await.unwrap()); | |||
| } | |||
|
|
|||
| #[tokio::test] | |||
There was a problem hiding this comment.
Thanks @jonahgao, nice PR, I would also add a test with some edge cases like nested alias, empty string alias
jonahgao
commented
Jan 15, 2025
| #[tokio::test] | ||
| async fn test_alias_empty() -> Result<()> { | ||
| let df = create_test_table("test").await?.alias("")?; | ||
| let expected = "SubqueryAlias: [a:Utf8, b:Int32]\ |
There was a problem hiding this comment.
We allow creating TableReference from empty str.
jonahgao
commented
Jan 15, 2025
| .alias("alias1")? | ||
| .alias("alias2")?; | ||
| let expected = "SubqueryAlias: alias2 [a:Utf8, b:Int32, one:Int32]\ | ||
| \n SubqueryAlias: alias1 [a:Utf8, b:Int32, one:Int32]\ |
There was a problem hiding this comment.
This layer is redundant, but SubqueryAliases won’t appear in the physical plan
comphead
approved these changes
Jan 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #14112.
Rationale for this change
The new
alias()method applies an alias to an existing DataFrame by wrapping aSubqueryAlias. It is useful for implementing self-joins.What changes are included in this PR?
Are these changes tested?
Yes
Are there any user-facing changes?
New API.