Add tests for date_part on columns + timestamps with / without timezones #13732
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Dec 11, 2024
findepi
approved these changes
Dec 12, 2024
| @@ -876,3 +1070,5 @@ true | |||
|
|
|||
| query error DataFusion error: Internal error: unit Nanosecond not supported | |||
| SELECT (date_part('nanosecond', now()) = EXTRACT(nanosecond FROM now())) | |||
|
|
|||
|
|
|||
There was a problem hiding this comment.
git encourages against trailing empty lines
We could add file ending normalization to slt --complete mode.
There was a problem hiding this comment.
I removed the trailing whitespace in bc90fcc
|
I test with #13372 and all test here pass |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
TypeSignatureClassfor mixed type function signature #13372Rationale for this change
It wasn't clear to me that there is coverage for date_part with timestamps that are:
What changes are included in this PR?
Add coverage for:
TypeSignatureClassfor mixed type function signature #13372Are these changes tested?
Only tests
Are there any user-facing changes?
No, only tests