Increase minimum supported Rust version (MSRV) to 1.80 #13622
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current goal is to support four last stable versions or versions for 4 months whichever is lower. Given 1.80.0 was released on: 25 July, 2024 it's over 4 months old and 1.79 does not need to be supported.
github-actions
bot
added
core
alamb
reviewed
Dec 2, 2024
There was a problem hiding this comment.
Thanks @findepi
I agree with @comphead
Here is one place
datafusion/datafusion-cli/Dockerfile
Line 18 in 56946b4
I tried this and it worked on my machine 👍
docker run rust:1.80-bookworm
worked on my machine
github-actions
bot
added
the
development-process
comphead
approved these changes
Dec 3, 2024
findepi
deleted the
findepi/increase-minimum-supported-rust-version-msrv-to-1-80-75ed5d
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current goal is to support four last stable versions or versions for 4 months whichever is lower. Given 1.80.0 was released on: 25 July, 2024 it's over 4 months old and 1.79 does not need to be supported.