Test sort merge join on TPC-H benchmark #13572
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
comphead
reviewed
Nov 26, 2024
There was a problem hiding this comment.
Thanks @Dandandan I'll check this later.
Earlier there was introduced a env var to run TPCH benches with SMJ enabled.
comphead
reviewed
Nov 27, 2024
There was a problem hiding this comment.
Thanks @Dandandan it looks great. One question, is it supposed to have an SMJ in expected plans? I picked some plan files and haven't noticed SMJ plan nodes there
No, they aren't supposed to, I only moved the existing hash join plans and tested both hash join as sort merge join for answers. |
|
Thanks for the review @comphead |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #13573
Rationale for this change
More testing for sort merge join
What changes are included in this PR?
datafusion.optimizer.prefer_hash_join = falseAre these changes tested?
Are there any user-facing changes?