Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support DEALLOCATE to remove prepared statements #13327

Merged
merged 1 commit into from
Nov 10, 2024
Merged

feat: support DEALLOCATE to remove prepared statements #13327

merged 1 commit into from
Nov 10, 2024

Conversation

jonahgao
Copy link
Member

@jonahgao jonahgao commented Nov 9, 2024

Which issue does this PR close?

Follow-up of #13242

Rationale for this change

Support the DEALLOCATE sql statement to remove prepared plans.
A typical usage is

> prepare p(int) as select $1;
0 row(s) fetched.
Elapsed 0.003 seconds.

> deallocate p;
0 row(s) fetched.
Elapsed 0.002 seconds.

What changes are included in this PR?

Are these changes tested?

Yes

Are there any user-facing changes?

No

@github-actions github-actions bot added sql SQL Planner logical-expr Logical plan and expressions core Core DataFusion crate sqllogictest SQL Logic Tests (.slt) labels Nov 9, 2024
goldmedal
goldmedal approved these changes Nov 10, 2024
View reviewed changes
Copy link
Contributor

@goldmedal goldmedal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @jonahgao. LGTM but one suggestion. 👍

datafusion/sqllogictest/test_files/prepare.slt Show resolved Hide resolved
@jonahgao
Copy link
Member Author

Thanks @jatin510 @goldmedal for the review

@jonahgao jonahgao merged commit a20b318 into apache:main Nov 10, 2024
25 checks passed
@jonahgao jonahgao deleted the deallocate branch November 10, 2024 14:04
jayzhan211 pushed a commit to jayzhan211/datafusion that referenced this pull request Nov 12, 2024
@jonahgao @jayzhan211
feat: support DEALLOCATE to remove prepared statements (apache#13327)
951a766
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@goldmedal goldmedal goldmedal approved these changes

@jatin510 jatin510 jatin510 approved these changes

Assignees
No one assigned
Labels
core Core DataFusion crate logical-expr Logical plan and expressions sql SQL Planner sqllogictest SQL Logic Tests (.slt)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jonahgao @goldmedal @jatin510