refactor: move PREPARE/EXECUTE into LogicalPlan::Statement
#13311
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
sql
jonahgao
commented
Nov 8, 2024
| @@ -311,6 +311,7 @@ fn optimize_projections( | |||
| | LogicalPlan::Explain(_) | |||
| | LogicalPlan::Analyze(_) | |||
| | LogicalPlan::Subquery(_) | |||
| | LogicalPlan::Statement(_) | |||
There was a problem hiding this comment.
Added a slt test for this change.
alamb
approved these changes
Nov 8, 2024
| } | ||
|
|
||
| // Manual implementation needed because of `schema` field. Comparison excludes this field. | ||
| impl PartialOrd for TransactionStart { |
There was a problem hiding this comment.
this is a nice cleanup (not to have a schema as a field 👌 nice
jayzhan211
pushed a commit
to jayzhan211/datafusion
that referenced
this pull request
Nov 12, 2024
…13311) * refactor: move PREPARE/EXECUTE into `LogicalPlan::Statement` * Fix cargo doc * Restore TableScan * Fix cargo doc
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
See #13242 (comment)
Rationale for this change
Move
LogicalPlan::PrepareandLogicalPlan::ExecuteintoLogicalPlan::Statement.They are more suitable for being implemented as statements. This can also reduce the variants of
LogicalPlan.What changes are included in this PR?
LogicalPlan::StatementPartialOrdAre these changes tested?
Yes. By existing tests.
Are there any user-facing changes?
Yes