Enable clone_on_ref_ptr clippy lint on physical-expr-common crate

datafusion/physical-expr-common/src/binary_map.rs

@@ -349,10 +349,14 @@ where
         let batch_hashes = &mut self.hashes_buffer;
         batch_hashes.clear();
         batch_hashes.resize(values.len(), 0);
-        create_hashes(&[values.clone()], &self.random_state, batch_hashes)
-            // hash is supported for all types and create_hashes only
-            // returns errors for unsupported types
-            .unwrap();
+        create_hashes(
+            &[Arc::<dyn Array>::clone(values)],
+            &self.random_state,
+            batch_hashes,
+        )
+        // hash is supported for all types and create_hashes only
+        // returns errors for unsupported types
+        .unwrap();
 
         // step 2: insert each value into the set, if not already present
         let values = values.as_bytes::<B>();

datafusion/physical-expr-common/src/binary_view_map.rs

@@ -244,10 +244,14 @@ where
         let batch_hashes = &mut self.hashes_buffer;
         batch_hashes.clear();
         batch_hashes.resize(values.len(), 0);
-        create_hashes(&[values.clone()], &self.random_state, batch_hashes)
-            // hash is supported for all types and create_hashes only
-            // returns errors for unsupported types
-            .unwrap();
+        create_hashes(
+            &[Arc::<dyn Array>::clone(values)],
+            &self.random_state,
+            batch_hashes,
+        )
+        // hash is supported for all types and create_hashes only
+        // returns errors for unsupported types
+        .unwrap();
 
         // step 2: insert each value into the set, if not already present
         let values = values.as_byte_view::<B>();

datafusion/physical-expr-common/src/lib.rs

@@ -15,6 +15,9 @@
 // specific language governing permissions and limitations
 // under the License.
 
+// Make cheap clones clear: https://github.com/apache/datafusion/issues/11143
+#![deny(clippy::clone_on_ref_ptr)]
+
 //! Physical Expr Common packages for [DataFusion]
 //! This package contains high level PhysicalExpr trait
 //!

datafusion/physical-expr-common/src/tree_node.rs

@@ -62,7 +62,11 @@ impl<T> ExprContext<T> {
     }
 
     pub fn update_expr_from_children(mut self) -> Result<Self> {
-        let children_expr = self.children.iter().map(|c| c.expr.clone()).collect();
+        let children_expr = self
+            .children
+            .iter()
+            .map(|c| Arc::<dyn PhysicalExpr>::clone(&c.expr))
+            .collect();
         self.expr = with_new_children_if_necessary(self.expr, children_expr)?;
         Ok(self)
     }

datafusion/physical-expr-common/src/utils.rs

@@ -99,7 +99,9 @@ pub fn scatter(mask: &BooleanArray, truthy: &dyn Array) -> Result<ArrayRef> {
 pub fn reverse_order_bys(order_bys: &LexOrdering) -> LexOrdering {
     order_bys
         .iter()
-        .map(|e| PhysicalSortExpr::new(e.expr.clone(), !e.options))
+        .map(|e| {
+            PhysicalSortExpr::new(Arc::<dyn PhysicalExpr>::clone(&e.expr), !e.options)
+        })
         .collect()
 }