fix: Fix stddev indeterministically producing NAN #13248
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eejbyfeldt
force-pushed
the
i-13247-variance-correctness-bug-nan
branch
from
82219b5 to
2580bcc
Compare
In the VarianceGroupAccumulator we were missing a `count == 0` check that is present in the normal Accumulator. This mostly does not matter except for the case where the first state to be merged has `count == 0` then the `merge` function will incorrectly calculate a new m2 of NAN which will propagate to the final result. This fixes the bug bu adding the missing `count == 0` check.
eejbyfeldt
force-pushed
the
i-13247-variance-correctness-bug-nan
branch
from
2580bcc to
3265483
Compare
findepi
reviewed
Nov 4, 2024
| @@ -316,6 +316,7 @@ fn merge( | |||
| mean2: f64, | |||
| m22: f64, | |||
| ) -> (u64, f64, f64) { | |||
| debug_assert!(count != 0 || count2 != 0, "Cannot merge two empty states"); | |||
There was a problem hiding this comment.
I don't exactly know how it works. Is supporting this not needed?
There was a problem hiding this comment.
It is a precondition of using this function. So support is not needed here, but expected to be handled by callers. When both counts are 0 then also mean and m2 is 0 and the correct result would also be all 0.
There was a problem hiding this comment.
i should have checked the callers. thanks. 👍
findepi
approved these changes
Nov 4, 2024
alamb
approved these changes
Nov 5, 2024
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #13247
Rationale for this change
In the VarianceGroupAccumulator we were missing a
count == 0checkthat is present in the normal Accumulator. This mostly does not matter
except for the case where the first state to be merged has
count == 0then the
mergefunction will calculate a new m2 of NAN which willpropagate to the final result.
What changes are included in this PR?
This fixes the bug bu adding the missing
count == 0check.Are these changes tested?
New and existing tests.
Are there any user-facing changes?
Correctness issue is fixed.