Support timestamp(n) SQL type #13231
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
caicancai
reviewed
Nov 2, 2024
| @@ -466,7 +467,14 @@ impl<'a, S: ContextProvider> SqlToRel<'a, S> { | |||
| // Timestamp Without Time zone | |||
| None | |||
| }; | |||
| Ok(DataType::Timestamp(TimeUnit::Nanosecond, tz.map(Into::into))) | |||
| let precision = match precision { | |||
There was a problem hiding this comment.
Can I assume this is the standard between vector api and precision?
I am currently working on a similar problem in the process of adapting Arrow in the Calcite community.
alamb
approved these changes
Nov 3, 2024
| 2020-09-08T13:42:29.190855123 | ||
|
|
||
| query P rowsort | ||
| SELECT CAST(ts AS timestamp(0)) FROM ts_data_nanos; |
There was a problem hiding this comment.
Thanks. The Calcite Arrow adapter will also comply with this standard
caicancai
approved these changes
Nov 3, 2024
|
Thanks again @findepi |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to #13230