Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

minor: Update test case for issue #5771 showing it is resolved #13180

Merged
merged 1 commit into from
Oct 30, 2024

Conversation

eejbyfeldt
Copy link
Contributor

Which issue does this PR close?

Closes #5771

Rationale for this change

Keeping issues and code comments up to date.

What changes are included in this PR?

Removing old outdate comment.

Are these changes tested?

Existing tests.

Are there any user-facing changes?

No.

With apache#13066 we run optimizer rules on subquries by default which
resolved issue apache#5771
@github-actions github-actions bot added the core Core DataFusion crate label Oct 30, 2024
@eejbyfeldt eejbyfeldt marked this pull request as ready for review October 30, 2024 09:06
Copy link
Contributor

@goldmedal goldmedal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @eejbyfeldt LGTM

@goldmedal goldmedal merged commit 8c48c39 into apache:main Oct 30, 2024
24 checks passed
@eejbyfeldt eejbyfeldt deleted the i-5771-update-test branch October 30, 2024 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Core DataFusion crate
Projects
None yet
2 participants