Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation: Add API deprecation policy #13083

Merged
merged 3 commits into from
Oct 24, 2024
Merged

Documentation: Add API deprecation policy #13083

merged 3 commits into from
Oct 24, 2024

Conversation

comphead
Copy link
Contributor

Which issue does this PR close?

Closes #13077 .

Rationale for this change

DataFusion need to state the clear policy when the deprecated methods can be removed from the codebase to let the users enough time to migrate and keep the API hygiene

What changes are included in this PR?

Are these changes tested?

Are there any user-facing changes?

@github-actions github-actions bot added the documentation Improvements or additions to documentation label Oct 23, 2024
@comphead comphead requested review from alamb and andygrove October 23, 2024 16:10
Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me -- thank you @comphead

under the License.
-->

# API health policy
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should also add a link to the main README as well -- perhaps something on https://github.com/apache/datafusion?tab=readme-ov-file#apache-datafusion?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry @alamb i'm not quite following

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was thinking that since this policy is in its own file (not in the README) it is not visible to people when they open https://github.com/apache/datafusion

I think it would make it easier to find if we either put the policy directly in the https://github.com/apache/datafusion/blob/main/README.md file or if not left a link in that file that points here

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That totally makes sense

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added small policy description and a link from README to the policy

- clearly mark the API as deprecated and specify the exact DataFusion version in which it was deprecated.
- concisely describe the preferred API, if relevant

API deprecation example:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@comphead comphead merged commit 631408b into apache:main Oct 24, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Document how long deprecated methods should be kept
2 participants