Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Minor] Update info/list of TPC-DS queries #13075

Merged
merged 1 commit into from
Oct 23, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions datafusion/core/benches/sql_planner.rs
Original file line number Diff line number Diff line change
Expand Up @@ -203,10 +203,8 @@ fn criterion_benchmark(c: &mut Criterion) {

let tpcds_ctx = register_defs(SessionContext::new(), tpcds_schemas());

// 10, 35: Physical plan does not support logical expression Exists(<subquery>)
// 45: Physical plan does not support logical expression (<subquery>)
// 41: Optimizing disjunctions not supported
let ignored = [10, 35, 41, 45];
// 41: check_analyzed_plan: Correlated column is not allowed in predicate
let ignored = [41];

let raw_tpcds_sql_queries = (1..100)
.filter(|q| !ignored.contains(q))
Expand Down
4 changes: 2 additions & 2 deletions datafusion/core/tests/tpcds_planning.rs
Original file line number Diff line number Diff line change
Expand Up @@ -230,8 +230,8 @@ async fn tpcds_logical_q40() -> Result<()> {

#[tokio::test]
#[ignore]
// Optimizer rule 'scalar_subquery_to_join' failed: Optimizing disjunctions not supported!
// issue: https://github.com/apache/datafusion/issues/5368
// check_analyzed_plan: Correlated column is not allowed in predicate
// issue: https://github.com/apache/datafusion/issues/13074
async fn tpcds_logical_q41() -> Result<()> {
create_logical_plan(41).await
}
Expand Down