Move filtered SMJ right join out of join_partial phase
#13053
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
physical-expr
comphead
commented
Oct 22, 2024
| @@ -746,21 +750,21 @@ fn last_index_for_row( | |||
| // `false` - the row sent as NULL joined row | |||
| fn get_corrected_filter_mask( | |||
| join_type: JoinType, | |||
| indices: &UInt64Array, | |||
| ids: &[usize], | |||
| row_indices: &UInt64Array, | |||
There was a problem hiding this comment.
renamed variables for readability
comphead
commented
Oct 22, 2024
| @@ -100,14 +100,13 @@ Alice 100 Alice 2 | |||
| Alice 50 Alice 1 | |||
| Alice 50 Alice 2 | |||
|
|
|||
| # Uncomment when filtered RIGHT moved | |||
| # right join with join filter | |||
alamb
reviewed
Oct 22, 2024
| async fn test_right_join_1k_filtered() { | ||
| JoinFuzzTestCase::new( | ||
| make_staggered_batches(1000), | ||
| make_staggered_batches(1000), | ||
| JoinType::Right, | ||
| Some(Box::new(col_lt_col_filter)), | ||
| ) | ||
| .run_test(&[JoinTestType::NljHj], false) | ||
| .run_test(&[JoinTestType::HjSmj, JoinTestType::NljHj], false) |
| @@ -3643,102 +3664,12 @@ mod tests { | |||
|
|
|||
| #[tokio::test] | |||
| async fn test_left_semi_join_filtered_mask() -> Result<()> { | |||
| let schema = Arc::new(Schema::new(vec
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Related #12359 .
Follow up on #12764
Rationale for this change
Same as #12764 but for Right Outer join
What changes are included in this PR?
Are these changes tested?
Are there any user-facing changes?