Support filter in cross join elimination #13025
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
optimizer
austin362667
approved these changes
Oct 21, 2024
comphead
reviewed
Oct 21, 2024
| @@ -253,13 +269,7 @@ fn flatten_join_inputs( | |||
| fn can_flatten_join_inputs(plan: &LogicalPlan) -> bool { | |||
| // can only flatten inner / cross joins | |||
There was a problem hiding this comment.
perhaps we can add the reason why only inner/cross joins can be flattened?
There was a problem hiding this comment.
I think the reason is that the current code doesn't support that / it's not obvious how it could work for non-inner joins.
alamb
approved these changes
Oct 21, 2024
There was a problem hiding this comment.
This PR makes sense to me -- thank you @Dandandan and @comphead
| @@ -660,7 +663,17 @@ mod tests { | |||
| .filter(col("t1.a").gt(lit(15u32)))? | |||
| .build()?; | |||
|
|
|||
| assert_optimization_rule_fails(plan); | |||
| let expected = vec
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #7549, #4877
Rationale for this change
Simplifying optimization rule and supporting an extra case, adding more opportunity for optimization.
What changes are included in this PR?
Are these changes tested?
Are there any user-facing changes?