Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor: Fixed regexpr_match docs #13008

Merged
merged 3 commits into from
Oct 18, 2024
Merged

Conversation

jonathanc-n
Copy link
Contributor

Which issue does this PR close?

Closes #13004 .

Rationale for this change

What changes are included in this PR?

Are these changes tested?

Are there any user-facing changes?

@github-actions github-actions bot added the documentation Improvements or additions to documentation label Oct 18, 2024
Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @jonathanc-n

I also took the liberty of regenerating the docs and merging this branch from main

@jonathanc-n
Copy link
Contributor Author

@alamb Thank you, sorry forgot to regenerate.

@alamb alamb merged commit 8c9b915 into apache:main Oct 18, 2024
25 checks passed
@alamb
Copy link
Contributor

alamb commented Oct 18, 2024

Thanks again @jonathanc-n

@@ -119,7 +119,7 @@ fn get_regexp_match_doc() -> &'static Documentation {
DOCUMENTATION.get_or_init(|| {
Documentation::builder()
.with_doc_section(DOC_SECTION_REGEX)
.with_description("Returns a list of [regular expression](https://docs.rs/regex/latest/regex/#syntax) matches in a string.")
.with_description("Returns the first [regular expression](https://docs.rs/regex/latest/regex/#syntax) matche in a string.")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

matche ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, i'll fix that rlly quick.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed in #13014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation functions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Minor: fix regexp_match function documentation
3 participants