Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Add documentation about conventional commits #12971

Merged
merged 2 commits into from
Oct 16, 2024

Conversation

andygrove
Copy link
Member

@andygrove andygrove commented Oct 16, 2024

Which issue does this PR close?

N/A

Rationale for this change

We generate changelogs based on PR titles where PRs following the conventional commits specification, and also based on labels associated with PRs, but we did not documentation for this process.

What changes are included in this PR?

This PR adds documentation.

Are these changes tested?

Are there any user-facing changes?

@github-actions github-actions bot added the documentation Improvements or additions to documentation label Oct 16, 2024
Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you -- I didn't know about this. ❤️

looking for titles starting with prefixes such as `fix:`, `feat:`, `docs:`, or `chore:`. We do not enforce this
convention but encourage its use if you want your PR to feature in the correct section of the changelog.

The change log generator will also look at GitHub labels such as `bug`, `enhancement`, or `api change`, and labels
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@andygrove andygrove merged commit d8e4e92 into apache:main Oct 16, 2024
5 checks passed
@andygrove andygrove deleted the conv-commit branch October 16, 2024 22:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants