Added expresion to "with_standard_argument" #12926
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Omega359
reviewed
Oct 14, 2024
Omega359
reviewed
Oct 14, 2024
Omega359
reviewed
Oct 14, 2024
Omega359
reviewed
Oct 14, 2024
github-actions
bot
added
the
documentation
|
@Omega359 Should be good now! thanks for the review |
Omega359
reviewed
Oct 17, 2024
| @@ -295,10 +295,10 @@ fn get_concat_ws_doc() -> &'static Documentation { | |||
| "separator", | |||
| "Separator to insert between concatenated strings.", | |||
| ) | |||
| .with_standard_argument("str", "String") | |||
| .with_standard_argument("str", Some("String")) | |||
| .with_standard_argument( | |||
There was a problem hiding this comment.
Suggested change
| .with_standard_argument( | |
| .with_argument( |
There was a problem hiding this comment.
I think github messed up the line, should be for this one
.with_standard_argument(
"str_n",
Some("Subsequent string expressions to concatenate."),
alamb
approved these changes
Oct 17, 2024
There was a problem hiding this comment.
Looks nice to me. Thank you @jonathanc-n @findepi and @Omega359
|
The CI failure https://github.com/apache/datafusion/actions/runs/11388211741/job/31684979969?pr=12926n should be fixed by #12991 I think |
|
@alamb It doesn't seem to be passing still despite the pr merge |
|
I @jonathanc-n -- maybe you could try to merge up from main locally and rerun update_docs.sh again? Maybe there is a logical conflict somewhere |
|
LGTM :) |
alamb
approved these changes
Oct 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #.
Rationale for this change
In #12880, there is a discussion to add an option for when there is just 'expression' put in the docs.
What changes are included in this PR?
Added an option for "with_standard_argument", when None is passed through it passes the standard argument for when 'expression' is passed in.
Are these changes tested?
Are there any user-facing changes?