Optimize iszero
function (3-5x faster)
#12881
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Didn't create an issue beforehand.
Rationale for this change
iszero
runs faster usingBooleanArray::from_unary
.I think this is because we don't need to branch on each value to check if it's null, which the
.iter
insidemake_function_scalar_inputs_return_type
is doing.What changes are included in this PR?
make_function_scalar_inputs_return_type
use withBooleanArray::from_unary
Are these changes tested?
Yes, with existing tests.
Are there any user-facing changes?
Faster
iszero
. I don't expect this function to be a bottleneck anywhere, but at least it's a bit faster now.