Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Bug in Display for ScalarValue::Struct #12856

Merged
merged 2 commits into from
Oct 10, 2024

Conversation

avantgardnerio
Copy link
Contributor

Which issue does this PR close?

Closes #12855.

Rationale for this change

Fix the bug

What changes are included in this PR?

A broken test
(TODO) bug fix

Are these changes tested?

Yes

Are there any user-facing changes?

@github-actions github-actions bot added the common Related to common crate label Oct 10, 2024
@avantgardnerio avantgardnerio changed the title broken commit Fix Bug in Display for ScalarValue::Struct Oct 10, 2024
@avantgardnerio avantgardnerio marked this pull request as ready for review October 10, 2024 16:25
Copy link
Member

@andygrove andygrove left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @avantgardnerio

Copy link
Contributor

@thinkharderdev thinkharderdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@avantgardnerio avantgardnerio merged commit 101e455 into apache:main Oct 10, 2024
24 checks passed
@avantgardnerio avantgardnerio deleted the bg_scalar_fmt branch October 10, 2024 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
common Related to common crate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug in Display for ScalarValue::Struct
3 participants