Migrate documentation for all core functions from scalar_functions.md to code #12854
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
documentation
Co-authored-by: Andrew Lamb <[email protected]>
|
@Omega359 This looks good to me! |
alamb
approved these changes
Oct 11, 2024
There was a problem hiding this comment.
Looks good to me -- thank you @Omega359 and @jonathanc-n
This PR has a merge conflict so I merged up from main to resolve it and plan to merge this PR when CI is complete
| @@ -133,7 +134,7 @@ impl ScalarUDFImpl for GetFieldFunc { | |||
| DataType::Struct(fields) if fields.len() == 2 => { | |||
| // Arrow's MapArray is essentially a ListArray of structs with two columns. They are | |||
| // often named "key", and "value", but we don't require any specific naming here; | |||
| // instead, we assume that the second columnis the "value" column both here and in | |||
| // instead, we assume that the second column is the "value" column both here and in | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #12801
Rationale for this change
Documentation migration
What changes are included in this PR?
docs, minor updates/improvements in getfield udf.
Are these changes tested?
Yes.
Are there any user-facing changes?
Docs updated.