API from ParquetExec to ParquetExecBuilder
#12799
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
fyi @NGA-TRAN |
alamb
changed the title
ParquetExec to ParquetExecBuilderParquetExec to ParquetExecBuilder
alamb
commented
Oct 7, 2024
| @@ -479,9 +544,15 @@ impl ParquetExec { | |||
| self.pruning_predicate.as_ref() | |||
| } | |||
|
|
|||
| /// return the optional file reader factory | |||
There was a problem hiding this comment.
I added this API for completeness
alamb
commented
Oct 7, 2024
NGA-TRAN
approved these changes
Oct 7, 2024
Co-authored-by: Nga Tran <[email protected]>
|
Thanks again @jayzhan211 and @NGA-TRAN |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #12737
Closes #12726
Rationale for this change
See #12737 for rationale (basically many times we manipulate a
ParquetExecdownstream we end up needing to create a builder from an existingParquetExecWhat changes are included in this PR?
Changes:
ParquetExec::into_builder()methodAre these changes tested?
Yes
Are there any user-facing changes?
New API and Docs