-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove redundant aggregate/window/scalar function documentation #12745
Conversation
@@ -56,45 +53,6 @@ avg(expression) | |||
|
|||
- `mean` | |||
|
|||
### `bit_and` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These are in the new functions here: https://datafusion.apache.org/user-guide/sql/aggregate_functions_new.html
@@ -339,23 +338,6 @@ ln(numeric_expression) | |||
- **numeric_expression**: Numeric expression to operate on. | |||
Can be a constant, column, or function, and any combination of arithmetic operators. | |||
|
|||
### `log` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- [nullif](#nullif) | ||
- [nvl](#nvl) | ||
- [nvl2](#nvl2) | ||
- [ifnull](#ifnull) | ||
|
||
### `coalesce` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@@ -644,7 +608,6 @@ _Alias of [nvl](#nvl)._ | |||
|
|||
## String Functions | |||
|
|||
- [ascii](#ascii) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@@ -665,7 +628,6 @@ _Alias of [nvl](#nvl)._ | |||
- [replace](#replace) | |||
- [reverse](#reverse) | |||
- [right](#right) | |||
- [rpad](#rpad) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@@ -1257,102 +1183,18 @@ find_in_set(str, strlist) | |||
- **str**: String expression to find in strlist. | |||
- **strlist**: A string list is a string composed of substrings separated by , characters. | |||
|
|||
## Binary String Functions |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@@ -1727,49 +1568,6 @@ Additional examples can be found [here] | |||
|
|||
- date_format | |||
|
|||
### `to_date` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@@ -3889,19 +3686,6 @@ md5(expression) | |||
|
|||
#### Arguments | |||
|
|||
- **expression**: String expression to operate on. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- [rank](#rank) | ||
- [dense_rank](#dense_rank) | ||
- [ntile](#ntile) | ||
|
||
### `row_number` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Thank you for the review @jayzhan211 |
Which issue does this PR close?
Part of #12740
Rationale for this change
@Omega359 has created the basic framework for automatically generating content in #12668
There will be a period of transition as we migrate the existing content to the new code style
We should make it it clearer what functions and documentation remain to port during this transition period by ensuring there is no duplicated content
#12743 makes it clearer how to find other documentation
What changes are included in this PR?
Remove the static function definitions for all functions that are now auto generated (I will comment inline)
Are these changes tested?
I manually built the docs
Are there any user-facing changes?