[Minor] Improve error message when bitwise_* operator takes wrong unsupported type #12646
Conversation
| @@ -24,7 +24,7 @@ use arrow::compute::kernels::bitwise::{ | |||
| bitwise_xor, bitwise_xor_scalar, | |||
| }; | |||
| use arrow::datatypes::DataType; | |||
| use datafusion_common::internal_err; | |||
| use datafusion_common::plan_err; | |||
There was a problem hiding this comment.
Perhaps not_impl_err would be more appropriate?
https://docs.rs/datafusion/latest/datafusion/common/macro.not_impl_err.html
There was a problem hiding this comment.
it seems unlikely that we would support such an operation so plan_err should be good right ? However, I may be overlooking some factors. Could you please clarify if there's a specific rationale behind this suggestion that I might have missed?
There was a problem hiding this comment.
I was thinking that most plan_err s are issues with a user's query (some bug they should fix) where as not_impl signals that there isn't some bug with the query
This is kind of documented here:
There was a problem hiding this comment.
Thats clear. Thank You
|
Plan error is certainly better than internal error. We can consider switching to not implemented error as a follow on PR Thanks @dharanad |
Which issue does this PR close?
Closes #11249
Rationale for this change
What changes are included in this PR?
Are these changes tested?
Are there any user-facing changes?