Sort metrics alphabetically in EXPLAIN ANALYZE output #12568
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #12567.
Rationale for this change
From
ParquetExec
metrics, with predicate pushdown enabled:For example,
pushdown_rows_matched
andpushdown_rows_pruned
(highlighted in the snippet) are far away from each other, even though they refer to roughly the same thing.The unstable sort also makes it hard to compare multiple
EXPLAIN ANALYZE
results.after this change, metrics for the same query look like this:
What changes are included in this PR?
Refinement of the partial order used in
MetricsSet::sorted_for_display
Are these changes tested?
Yes
Are there any user-facing changes?
More readable output. There doesn't seem to be any snippet in the documentation that needs to be updated to match the new behavior.