-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ignore case of with header row
in sql when creating external table
#1237
ignore case of with header row
in sql when creating external table
#1237
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Thank you @lichuan6
@lichuan6 there appears to be some failures on the CI checks |
OK, thanks @alamb for pointing it out. It seems using Currently, after changing signature from fn consume_token(&mut self, expected: &str) -> bool to fn consume_token(&mut self, expected: &Token) -> bool to do case-insensitive parsing, I created a new |
@Dandandan Could you please approve and make the tests run? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Thank you @lichuan6
Any thoughts @Dandandan ?
Hi, @Dandandan Could you please review this PR? |
If @Dandandan doesn't have anything to add I'll plan to merge this PR tomorrow |
Thanks again @lichuan6 |
Resolves #1242
Currently, creating an external table using
datafusion-cli
with this sql:will fail when
with header row
tokens are in lower case. This pr is a fix.