Extract drive-by fixes from PR 12135 for easier reviewing #12240
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
physical-expr
|
It looks like clippy failed due to some internal CI connectivity issue - I don't think I can rerun them by myself. |
Thanks @itsjunetime I have restarted the CI (you do need to be a datafusion committer to restart the jobs individually) One trick to get github to rerun the CI is to close the PR and then reopen it (that will trigger rerunning the whole PR) |
alamb
approved these changes
Sep 1, 2024
There was a problem hiding this comment.
Looks like a very nice set of cleanups to me @itsjunetime -- thank you
| @@ -51,12 +51,12 @@ use object_store::{ObjectMeta, ObjectStore}; | |||
| /// - the table provider can filter the table partition values with this expression | |||
| /// - the expression can be marked as `TableProviderFilterPushDown::Exact` once this filtering | |||
| /// was performed | |||
| pub fn expr_applicable_for_cols(col_names: &[String], expr: &Expr) -> bool { | |||
| pub fn expr_applicable_for_cols(col_names: &[&str], expr: &Expr) -> bool { | |||
There was a problem hiding this comment.
This is a nice removal of some clones 👍
| let rr = as_boolean_array($RIGHT).expect("boolean_op failed to downcast array"); | ||
| Ok(Arc::new($OP(&ll, &rr)?)) | ||
| }}; | ||
| #[inline] |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Helps with reviewing of #12135
Rationale for this change
These are just a few changes that make the code cleaner/easier to understand/etc that I added when filing #12135. It was pointed out to me, though, that these make the PR harder to review as there's a lot of changes not directly related to the PR. So I'm pulling those changes into this PR so that they are hidden from the diff once this is merged, thus making the PR easier to review.
What changes are included in this PR?
A few clean-ups that shouldn't change behavior at all.
Are these changes tested?
All tests pass just like they do on main.
Are there any user-facing changes?
Shouldn't be