Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix concat dictionary(int32, utf8) bug #12143

Merged
merged 2 commits into from
Aug 24, 2024

Conversation

thinh2
Copy link
Contributor

@thinh2 thinh2 commented Aug 23, 2024

Which issue does this PR close?

Closes #12101 .

Rationale for this change

Before this change, query to concat 2 dictionary columns will return error. This PR is to add support for concat dictionary columns in string_concat_coercion function.

What changes are included in this PR?

  • Add handler for string_concat_cocercion where lhs and rhs are Dictionary.
  • Update the sqllogictest to match the expectaion. There should be no error when concat columns or values of type Dictionary(int32, utf8)

Are these changes tested?

  • The sqllogictest is updated to match the expectation query results.

Are there any user-facing changes?

@github-actions github-actions bot added the sqllogictest SQL Logic Tests (.slt) label Aug 23, 2024
Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @thinh2 -- this looks perfect 🙏

@alamb alamb merged commit a58416c into apache:main Aug 24, 2024
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sqllogictest SQL Logic Tests (.slt)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot infer common string type for string concat operation Dictionary(Int32, Utf8) || Dictionary(Int32, Utf8)
2 participants