Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix compilation on main #12108

Merged
merged 1 commit into from
Aug 22, 2024
Merged

Fix compilation on main #12108

merged 1 commit into from
Aug 22, 2024

Conversation

alamb
Copy link
Contributor

@alamb alamb commented Aug 22, 2024

Which issue does this PR close?

Closes #.

Rationale for this change

Compilaton on main is broken due to a logical merge conflict between #12040 and #12046

error[E0308]: mismatched types
   --> datafusion/expr/src/logical_plan/builder.rs:402:52
    |
402 |         Filter::try_new_with_having(expr, Arc::new(self.plan))
    |                                           -------- ^^^^^^^^^ expected `LogicalPlan`, found `Arc<LogicalPlan>`
    |                                           |
    |                                           arguments to this function are incorrect
    |

What changes are included in this PR?

Fix compilation by updating API call

Are these changes tested?

Are there any user-facing changes?

@alamb alamb changed the title Fix compialtion on main Fix compilation on main Aug 22, 2024
@alamb alamb marked this pull request as ready for review August 22, 2024 10:20
@andygrove andygrove merged commit 9a1a92d into apache:main Aug 22, 2024
24 of 25 checks passed
@alamb alamb deleted the alamb/fix_compilation branch August 22, 2024 13:25
@alamb
Copy link
Contributor Author

alamb commented Aug 22, 2024

Thank you @andygrove

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants