Window UDF signature check #12045
Merged
Window UDF signature check #12045
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: jayzhan211 <[email protected]>
github-actions
bot
added
logical-expr
jayzhan211
commented
Aug 18, 2024
| 1 1 | ||
|
|
||
| # RowNumber expect 0 args. | ||
| query error |
There was a problem hiding this comment.
not an error on main
There was a problem hiding this comment.
Wild -- I double checked and you are right
DataFusion CLI v41.0.0
> create table t(a int, b int) as values (1, 2);
0 row(s) fetched.
Elapsed 0.015 seconds.
> select a, row_number() over (order by b) as rn from t;
+---+----+
| a | rn |
+---+----+
| 1 | 1 |
+---+----+
1 row(s) fetched.
Elapsed 0.006 seconds.
> select a, row_number(a) over (order by b) as rn from t;
+---+----+
| a | rn |
+---+----+
| 1 | 1 |
+---+----+
1 row(s) fetched.
Elapsed 0.002 seconds.Signed-off-by: jayzhan211 <[email protected]>
goldmedal
approved these changes
Aug 18, 2024
datafusion/expr/src/udwf.rs
Outdated
| /// Coerce arguments of a function call to types that the function can evaluate. | ||
| /// | ||
| /// This function is only called if [`WindowUDFImpl::signature`] returns [`crate::TypeSignature::UserDefined`]. Most | ||
| /// UDAFs should return one of the other variants of `TypeSignature` which handle common |
There was a problem hiding this comment.
Suggested change
| /// UDAFs should return one of the other variants of `TypeSignature` which handle common | |
| /// UDWFs should return one of the other variants of `TypeSignature` which handle common |
It looks like a typo (?
alamb
approved these changes
Aug 18, 2024
There was a problem hiding this comment.
Thanks @jayzhan211 and @goldmedal for the review
I didn't realize there was no signature checking 🤯
| @@ -95,6 +94,32 @@ pub fn data_types_with_aggregate_udf( | |||
| try_coerce_types(valid_types, current_types, &signature.type_signature) | |||
| } | |||
|
|
|||
| pub fn data_types_with_window_udf( | |||
There was a problem hiding this comment.
Can you please add documentation for this (pub) function? I think we could basically follow the pattern of the docs on data_types_with_scalar_udf above
| 1 1 | ||
|
|
||
| # RowNumber expect 0 args. | ||
| query error |
There was a problem hiding this comment.
Wild -- I double checked and you are right
DataFusion CLI v41.0.0
> create table t(a int, b int) as values (1, 2);
0 row(s) fetched.
Elapsed 0.015 seconds.
> select a, row_number() over (order by b) as rn from t;
+---+----+
| a | rn |
+---+----+
| 1 | 1 |
+---+----+
1 row(s) fetched.
Elapsed 0.006 seconds.
> select a, row_number(a) over (order by b) as rn from t;
+---+----+
| a | rn |
+---+----+
| 1 | 1 |
+---+----+
1 row(s) fetched.
Elapsed 0.002 seconds.Signed-off-by: jayzhan211 <[email protected]>
|
Thanks @goldmedal @alamb |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #.
Rationale for this change
We haven't add signature check for window udf, so we didn't get the expected error if the arguments failed to match the signature
What changes are included in this PR?
Are these changes tested?
Are there any user-facing changes?