-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: move coercion of union from builder to TypeCoercion
#11961
Merged
Merged
Changes from 1 commit
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
e019ccc
Improve type coercion for `UNION`
jonahgao 9fca957
fix clippy
jonahgao e69a1a1
fix test
jonahgao 6c3edd3
Merge branch 'main' into union_coercion
jonahgao b67f11c
fix sqllogictests
jonahgao 5ad7243
fix EliminateNestedUnion tests
jonahgao d96892c
Move tests to slt
jonahgao d672bbf
Merge branch 'main' into union_coercion
jonahgao 6c05d17
Move union_coercion to type_coercion.rs
jonahgao 21f93dc
fix tests
jonahgao c2235df
fix cargo doc
jonahgao 364ba12
Merge branch 'main' into union_coercion
jonahgao e5c2dc9
Improve error msg
jonahgao 723fd43
As static member
jonahgao 7e8b3f4
Avoid clone
jonahgao d42486e
Fix clippy
jonahgao File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❤️