feat: expose centroids in approx_percentile_cont fluent api #11878
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Michael-J-Ward
commented
Aug 8, 2024
| @@ -394,6 +394,21 @@ async fn test_fn_approx_percentile_cont() -> Result<()> { | |||
|
|
|||
| assert_batches_eq!(expected, &batches); | |||
|
|
|||
| // with number of centroids set | |||
| let expr = approx_percentile_cont(col("b"), lit(0.5), Some(lit(2))); | |||
There was a problem hiding this comment.
NOTE: I don't have SQL Server, so I did not verify that it produces this result.
I chose a choice for centroids that produced a different result than the default.
Michael-J-Ward
changed the title
|
I think technically speaking this is an API change as there is a new parameter, so I marked the PR thusly |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #11877.
Rationale for this change
The UDAF
approx_percentile_conthas a third optional argument that the fluent api does not currently expose.This PR add the 3rd optional argument, consistent with how array_slice and regexp_* fluent APIs expose optional arguments.
What changes are included in this PR?
Add
centroids: Option<Expr>to the fluent API.Are these changes tested?
Yes.
Are there any user-facing changes?
Yes. Any user of the
approx_percentile_contfluent API will need to addNonefor the optional argument.