refactor: move ExecutionPlan and related structs into dedicated mod #11759
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ruihang Xia <[email protected]>
alamb
approved these changes
Aug 1, 2024
| pub use crate::display::{DefaultDisplay, DisplayAs, DisplayFormatType, VerboseDisplay}; | ||
| pub(crate) use crate::execution_plan::execution_mode_from_children; |
There was a problem hiding this comment.
💯 -- I think these pub use means that this will have no effect on users use paths
andygrove
approved these changes
Aug 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Related to #11375
Rationale for this change
Try to break large
lib.rsinto small and dedicated files. Take the largest one as the beginning.During refactoring, I find this does help in improving readability. Like previous to this patch, re-exports (
pub use crate::xxx) are mixed with import (use xxx).What changes are included in this PR?
Move
ExecutionPlanand related structs/methods intoexecution_plan.rs.For compatibility, all items are re-exported in
lib.rsso others need not change their code to reference related structs.One thing I'm not sure about is whether we need another mod like
exec_utilfor those functions inexecution_planlikecollect,collect_partitionedorexecute_input_stream.Are these changes tested?
No need
Are there any user-facing changes?
No