fix: set null_equals_null
to false when convert_cross_join_to_inner_join
#11738
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #11704.
Rationale for this change
Given an example query:
The
push_down_filter
rule will convert the cross join into an inner join.null_equals_null
is only valid for equijoins, and when applying the corresponding equality predicate to the cross join, null does not equal null. So we should setnull_equals_null
to false in order to convert the cross join to an equivalent equijoin.What changes are included in this PR?
Are these changes tested?
Yes
Are there any user-facing changes?
No