-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename functions-array
to functions-nested
#11602
Changes from 9 commits
cb817d4
fd0d5fb
f309e86
727b25b
4fde39e
c7f97de
e5ca91f
55b0023
93bbcee
a05fe1f
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -458,7 +458,7 @@ | |
//! * [datafusion_execution]: State and structures needed for execution | ||
//! * [datafusion_expr]: [`LogicalPlan`], [`Expr`] and related logical planning structure | ||
//! * [datafusion_functions]: Scalar function packages | ||
//! * [datafusion_functions_array]: Scalar function packages for `ARRAY`s | ||
//! * [datafusion_functions_nested]: Scalar function packages for `ARRAY`s, `MAP`s and `STRUCT`s | ||
//! * [datafusion_optimizer]: [`OptimizerRule`]s and [`AnalyzerRule`]s | ||
//! * [datafusion_physical_expr]: [`PhysicalExpr`] and related expressions | ||
//! * [datafusion_physical_plan]: [`ExecutionPlan`] and related expressions | ||
|
@@ -569,10 +569,17 @@ pub mod functions { | |
pub use datafusion_functions::*; | ||
} | ||
|
||
/// re-export of [`datafusion_functions_array`] crate, if "array_expressions" feature is enabled | ||
/// re-export of [`datafusion_functions_nested`] crate, if "nested_expressions" feature is enabled | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Maybe we can leave a Something like #[deprecated(since = "41.0.0", note = "use datafusion-functions-nested instead")]
pub mod functions_array {
#[cfg(feature = "nested_expressions")]
pub use datafusion_functions_nested::*;
} We could do something similar with the feature flags, but maybe that is too complicated to be worth it There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Good idea. Thanks. I'll try to do it for the crate and feature. |
||
pub mod functions_nested { | ||
#[cfg(feature = "nested_expressions")] | ||
pub use datafusion_functions_nested::*; | ||
} | ||
|
||
/// re-export of [`datafusion_functions_nested`] crate as [`functions_array`] for backward compatibility, if "nested_expressions" feature is enabled | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 💯 |
||
#[deprecated(since = "41.0.0", note = "use datafusion-functions-nested instead")] | ||
pub mod functions_array { | ||
#[cfg(feature = "array_expressions")] | ||
pub use datafusion_functions_array::*; | ||
#[cfg(feature = "nested_expressions")] | ||
pub use datafusion_functions_nested::*; | ||
} | ||
|
||
/// re-export of [`datafusion_functions_aggregate`] crate | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have no better way to annotate a feature that is deprecated. Just leave a comment for it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is ok -- thank you